Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(godeltaprof): decouple pprof builder from delta computation with an interface #110

Merged
merged 6 commits into from
May 24, 2024

Conversation

korniltsev
Copy link
Collaborator

@korniltsev korniltsev commented May 23, 2024

  1. Add a new interface. It is useful for benchmarking and in the next PR will be used for OTLP proto building. The interface is still in internal folder
type ProfileBuilder interface {
	LocsForStack(stk []uintptr) (newLocs []uint64)
	Sample(values []int64, locs []uint64, blockSize int64)
	Build()
}
  1. Add a benchmark for delta computation using noopBuilder

@korniltsev korniltsev changed the title Korniltsev/decouple delta with builder chore(godeltaprof): decouple pprof builder from delta computation with an interfac May 23, 2024
@korniltsev korniltsev changed the title chore(godeltaprof): decouple pprof builder from delta computation with an interfac chore(godeltaprof): decouple pprof builder from delta computation with an interface May 23, 2024
@korniltsev korniltsev marked this pull request as ready for review May 23, 2024 10:14
Copy link

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@korniltsev korniltsev merged commit 07e7716 into main May 24, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants