Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: /debug/pprof/allocs instead of /debug/pprof/heap #36

Closed
jjangga0214 opened this issue Oct 8, 2023 · 2 comments
Closed

feat: /debug/pprof/allocs instead of /debug/pprof/heap #36

jjangga0214 opened this issue Oct 8, 2023 · 2 comments

Comments

@jjangga0214
Copy link

jjangga0214 commented Oct 8, 2023 •
edited
Loading

Hi!

It seems my Pyroscope scraps /debug/pprof/allocs instead of /debug/pprof/heap.
(I am new to Pyroscope)

Then shouldn't the express middleware handle /debug/pprof/allocs?

Thanks.
@jjangga0214 jjangga0214 changed the title feat: /debug/pprof/allocs feat: /debug/pprof/allocs instead of /debug/pprof/heap Oct 8, 2023
@jjangga0214 jjangga0214 changed the title feat: /debug/pprof/allocs instead of /debug/pprof/heap feat: /debug/pprof/allocs instead of /debug/pprof/heap Oct 8, 2023
@usermakename usermakename mentioned this issue Oct 25, 2023
Open
jjangga0214 added a commit to jjangga0214/pyroscope-nodejs that referenced this issue Nov 14, 2023
@jjangga0214
fix: handle /debug/pprof/allocs
4cc7758 
Close grafana#36
@jjangga0214 jjangga0214 mentioned this issue Nov 14, 2023
Closed
@simonswine
Copy link
Collaborator

I do think the pulling end needs to be fixed instead. As for nodejs we don't have memory allocation statistics.

@simonswine simonswine closed this as not planned Won't fix, can't repro, duplicate, stale May 23, 2024
@jjangga0214
Copy link
Author

jjangga0214 commented May 23, 2024 •
edited
Loading

@simonswine Got it. Is it a bug of the pulling end, or a thing that should be configured from the pulling end? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: handle /debug/pprof/allocs jjangga0214/pyroscope-nodejs
2 participants
@simonswine @jjangga0214