Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Windows #87

Open
bryanhuhta opened this issue May 29, 2024 · 1 comment
Open

Add support for Windows #87

bryanhuhta opened this issue May 29, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@bryanhuhta
Copy link
Contributor

Currently, we don't support Windows because of our usage of dynamic labels. The DataDog profiler doesn't support dynamic labels on Windows:

https://github.com/DataDog/pprof-nodejs/blob/e7d3e053d9816e64710533738ff827c0301b82fe/bindings/profilers/wall.cc#L33

The DD_WALL_USE_SIGPROF enables dynamic labels and if it is disabled, it throws an error here:

https://github.com/DataDog/pprof-nodejs/blob/e7d3e053d9816e64710533738ff827c0301b82fe/bindings/profilers/wall.cc#L609-L611

We always enable withContexts in or SDK:

We might be able to support Windows by disabling this configuration when we detect a Windows host, or by providing a way for users to turn it off. At the very least, we should provide a gentler failure case which is more helpful for users.

See #85 for an example of the SDK not working on Windows.

@bryanhuhta bryanhuhta added the enhancement New feature or request label May 29, 2024
@simonswine
Copy link
Collaborator

A good first step might also be to not break the application when running on windows, even if the profiler doens't work/run at all.

I also think we probably should have caught that ourselves by having a test for other OSes than linux (relates to #86)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants