-
Notifications
You must be signed in to change notification settings - Fork 971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backend] Introducing profiling capability with pyroscope #9469
Open
richard-julien
wants to merge
9
commits into
master
Choose a base branch
from
oob/profiling
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+296
−120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
filigran team
use to identify PR from the Filigran team
label
Dec 27, 2024
richard-julien
changed the title
[bakend] Introduce profiling capability with pyroscope
[bakend] Introducing profiling capability with pyroscope
Dec 27, 2024
richard-julien
changed the title
[bakend] Introducing profiling capability with pyroscope
[backend] Introducing profiling capability with pyroscope
Dec 27, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9469 +/- ##
==========================================
- Coverage 65.19% 65.16% -0.04%
==========================================
Files 628 630 +2
Lines 59961 59999 +38
Branches 6687 6693 +6
==========================================
+ Hits 39091 39097 +6
- Misses 20870 20902 +32 ☔ View full report in Codecov by Sentry. |
richard-julien
force-pushed
the
oob/profiling
branch
from
January 3, 2025 15:09
4fdc828
to
942b493
Compare
richard-julien
force-pushed
the
oob/profiling
branch
from
January 3, 2025 19:28
ec65ac8
to
d3a10fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Contains multiple subjects
Split between tracing and metrics graphql plugins.
We now have a dedicated plugin for metrics including a refactor to have an histogram for latency operations
Previously it was required to also activate tracing, that doesnt make sens.
Rework of ingestion manager logs
The ingestion manager currently log errors that doest not help. First step is to move logs to warn. The second step will be to catch and display a ingester status in the UI.
We need to have a way to profile CPU usage in the application.
This PR introduce pyroscope tooling based on datadog-pprof.
As pprof required some prebuilts executable, dockerfile needs to be modified to add specific prebuilt files.
Dynamic require is use instead of import to prevent importing all the tooling if not needed.
To test the behavior, you need:
Linux
The current pyroscope implementation is not working on windows even if the binary exists.
grafana/pyroscope-nodejs#87
grafana/pyroscope-nodejs#85
Deployment
OpenCTI configuration