Migrate from Jest to Vitest #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
nwalters512
commented
Sep 9, 2024
package-lock.json
Outdated
There was a problem hiding this comment.
AFAICT this file is no longer needed. Are there plans to merge #90?
|
👋 Hey @nwalters512! I seriously appreciate your batch of PRs here. These will go a long way to resolving a some repeated problems community members have reported. I'm going to merge in the following order:
Then cut a new release. |
|
@bryanhuhta 🎉 sounds great, I'm excited I'll be able to finally use Pyroscope in my app without weird hacks/workarounds. I'll be standing by to resolve merge conflicts or help resolve issues that might come up, particularly in #89. |
|
@nwalters512 Looks like merging #90 caused conflicts in this set of PRs. Can you pull in changes from |
|
@bryanhuhta done! |
bryanhuhta
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jest has poor support for ESM, which is standing in the way of #89. My hope is that this PR will unblock the ability to ship a functioning ESM distribution.
I took the liberty to remove some webpack dependencies and config files that, as far as I can tell, are unused. Let me know if you'd rather I do that in another PR.