fix(flameql): allow dots in tag name (#3479)

grafana · Aug 13, 2024 · b16b27a · b16b27a
1 parent 0bf22a4
commit b16b27a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/pkg/og/flameql/flameql.go b/pkg/og/flameql/flameql.go
@@ -97,7 +97,7 @@ func ValidateAppName(n string) error {
 }
 
 func IsTagKeyRuneAllowed(r rune) bool {
-	return (r >= 'a' && r <= 'z') || (r >= 'A' && r <= 'Z') || (r >= '0' && r <= '9') || r == '_'
+	return (r >= 'a' && r <= 'z') || (r >= 'A' && r <= 'Z') || (r >= '0' && r <= '9') || r == '_' || r == '.'
 }
 
 func IsAppNameRuneAllowed(r rune) bool {

diff --git a/pkg/og/flameql/flameql_test.go b/pkg/og/flameql/flameql_test.go
@@ -43,6 +43,7 @@ var _ = Describe("ValidateTagKey", func() {
 
 		testCases := []testCase{
 			{"foo_BAR_12_baz_qux", nil},
+			{"service.namespace", nil},
 
 			{ReservedTagKeyName, ErrTagKeyReserved},
 			{"", ErrTagKeyIsRequired},