fix(v2): set grpc.WithMaxCallAttempts() for the query backend client (#…

…3682) * Set grpc.WithMaxCallAttempts() for the query backend client * Revert timeout config * Add todo
grafana · Nov 14, 2024 · bef452a · bef452a
1 parent d320fcd
commit bef452a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/pkg/experiment/query_backend/client/client.go b/pkg/experiment/query_backend/client/client.go
@@ -37,6 +37,7 @@ func dial(address string, grpcClientConfig grpcclient.Config) (*grpc.ClientConn,
 	options = append(options,
 		grpc.WithUnaryInterceptor(otgrpc.OpenTracingClientInterceptor(opentracing.GlobalTracer())),
 		grpc.WithDefaultServiceConfig(grpcServiceConfig),
+		grpc.WithMaxCallAttempts(500),
 	)
 	return grpc.NewClient(address, options...)
 }

diff --git a/pkg/experiment/query_backend/concurrency.go b/pkg/experiment/query_backend/concurrency.go
@@ -38,6 +38,7 @@ var (
 
 func CreateConcurrencyInterceptor(logger log.Logger) (grpc.UnaryServerInterceptor, error) {
 	gclLog := newGclLogger(logger)
+	// TODO(aleks-p): Implement metric registry
 	serverLimit, err := limit.NewGradient2Limit("query-backend-concurrency-limit", minLimit, maxLimit, initialLimit, queueSizeFn, smoothing, longWindow, gclLog, nil)
 	if err != nil {
 		return nil, err