We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Now there are different flagsets for different commands, but for each command, it uses a global config structure:
type Config struct { Version bool Agent Agent `skip:“true”` Server Server `skip:“true”` Convert Convert `skip:“true”` Exec Exec `skip:“true”` DbManager DbManager `skip:“true”` }
just like the server command, the function is like this:
func startServer(cfg *config.Config)
i think it's better to use its own config for each command, the function should be like this:
func startServer(cfg *config.Server)
The text was updated successfully, but these errors were encountered:
Use the specific config structure for each command #192
9ad208d
91ba7fe
Closes: #192 Use the specific config structure for each command (#208)
2f33d66
Co-authored-by: kurylak <adrian.kurylak@nokia.com> Co-authored-by: Dmitry Filimonov <dmitry@pyroscope.io>
AdrK
Successfully merging a pull request may close this issue.
Now there are different flagsets for different commands, but for each command, it uses a global config structure:
just like the server command, the function is like this:
i think it's better to use its own config for each command, the function should be like this:
The text was updated successfully, but these errors were encountered: