Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pyroscope Process Lifecycle Refactoring #240

Closed
1 of 8 tasks
petethepig opened this issue Jun 15, 2021 · 1 comment
Closed
1 of 8 tasks

Pyroscope Process Lifecycle Refactoring #240

petethepig opened this issue Jun 15, 2021 · 1 comment
Labels
backend Mostly go code

Comments

@petethepig
Copy link
Member

petethepig commented Jun 15, 2021

  • move to cobra
  • standardize Exec functions in cli package
  • remove Cli related things from domain packages
  • move flags stuff to a separate package
  • move Server / Agent / Convert configs out of config package
  • split configs between CLI / domain logic
  • get rid of global logger
  • do more tests for cli interface
@petethepig
Copy link
Member Author

Some of it was done in #300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Mostly go code
Projects
None yet
Development

No branches or pull requests

2 participants