Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to view "head" or "tail" of functions in Flamegraph / Table #304

Closed
Rperry2174 opened this issue Jul 27, 2021 · 2 comments
Closed
Assignees
Labels
frontend Mostly JS code good first issue Good for newcomers

Comments

@Rperry2174
Copy link
Contributor

When looking at flamegraphs like this one:imageimage

Its not very useful to see this portion of the function name. It would be more convenient if there were some kind of ability to control the portion that is shown on the flamegraph.

In the picture above selected in the red box, (one of) the full function name is:
github.com/pyroscope-io/pyroscope/pkg/agent/upstream/direct.(*Direct).uploadLoop
however, the only portion that we can see is the 23 character portion which starts off the function:
github.com/pyroscope-io

In this case, if I am debugging an issue here and I can only see 23 characters, then I would like to have the option to see the last 23 characters rather than the first 23 characters. Something like:
ct.(*Direct).uploadLoop

While I still need to "hover" over the node to see the full function name, I think being able to toggle between these two views would be a nice feature to add. The same principle applies to the table as well:
image

From a UI standpoint I picture this probably being a "toggle" type button like this:
image

where:

  • head first: github.com/pyroscope-io
  • tail first: ct.(*Direct).uploadLoop

and it would probabily go next to the other toggle buttons above the flamegraph:
image

But once we build the functionality we can figure out what best UI/UX would be

@Rperry2174 Rperry2174 added the frontend Mostly JS code label Jul 27, 2021
@Rperry2174 Rperry2174 changed the title Add ability to truncate or "shift" displayed portion of nodes on the flamegraph/table Add ability to view "head" or "tail" of functions in Flamegraph / Table Jul 27, 2021
@Rperry2174 Rperry2174 added the good first issue Good for newcomers label Jul 29, 2021
@eh-am
Copy link
Collaborator

eh-am commented Aug 25, 2021

Let me give it a try.

@eh-am eh-am self-assigned this Aug 25, 2021
@eh-am eh-am mentioned this issue Aug 26, 2021
@Rperry2174
Copy link
Contributor Author

closed in #353

korniltsev pushed a commit that referenced this issue Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Mostly JS code good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants