Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reuse Table component everywhere #1403

Merged
merged 28 commits into from
Aug 17, 2022

Conversation

dogfrogfog
Copy link
Contributor

@dogfrogfog dogfrogfog commented Aug 15, 2022

Brief

Changes

  • all tables use same Table ui component
  • new ui component - Table
  • add ability to create custom tables by passing props
  • add useTableSort hook to make tables sortable (pass exported props to Table, no more actions)

Concerns

  • _
2022-08-17.14.33.41.mov

@github-actions
Copy link
Contributor

github-actions bot commented Aug 15, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 416.78 KB (+0.19% 🔺) 8.4 s (+0.19% 🔺) 3.3 s (-3.85% 🔽) 11.6 s
webapp/public/assets/app.css 15.18 KB (-0.82% 🔽) 304 ms (-0.82% 🔽) 0 ms (+100% 🔺) 304 ms
webapp/public/assets/styles.css 9.39 KB (-0.78% 🔽) 188 ms (-0.78% 🔽) 0 ms (+100% 🔺) 188 ms
packages/pyroscope-flamegraph/dist/index.js 90.77 KB (+0.71% 🔺) 1.9 s (+0.71% 🔺) 1.4 s (+24.57% 🔺) 3.2 s
packages/pyroscope-flamegraph/dist/index.node.js 90.64 KB (+0.69% 🔺) 1.9 s (+0.69% 🔺) 739 ms (-0.72% 🔽) 2.6 s
packages/pyroscope-flamegraph/dist/index.css 6.94 KB (+2.5% 🔺) 139 ms (+2.5% 🔺) 0 ms (+100% 🔺) 139 ms

@codecov
Copy link

codecov bot commented Aug 15, 2022

Codecov Report

Merging #1403 (d69e9c8) into main (e16de6f) will increase coverage by 0.16%.
The diff coverage is 68.43%.

@@            Coverage Diff             @@
##             main    #1403      +/-   ##
==========================================
+ Coverage   68.25%   68.41%   +0.16%     
==========================================
  Files         128      129       +1     
  Lines        4170     4241      +71     
  Branches     1130     1151      +21     
==========================================
+ Hits         2846     2901      +55     
- Misses       1319     1334      +15     
- Partials        5        6       +1     
Impacted Files Coverage Δ
...ackages/pyroscope-flamegraph/src/ProfilerTable.tsx 60.90% <37.15%> (-5.53%) ⬇️
webapp/javascript/ui/Table.module.scss 61.54% <61.54%> (ø)
webapp/javascript/ui/Table.tsx 86.16% <86.16%> (ø)
...e-flamegraph/src/FlameGraph/FlameGraphRenderer.tsx 50.00% <100.00%> (+1.75%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dogfrogfog
Copy link
Contributor Author

/create-server

@dogfrogfog
Copy link
Contributor Author

/create-server

@dogfrogfog
Copy link
Contributor Author

/create-server

@Rperry2174
Copy link
Contributor

/create-server

@eh-am
Copy link
Collaborator

eh-am commented Aug 17, 2022

Can you add an example to Storybook please!

@dogfrogfog dogfrogfog marked this pull request as ready for review August 17, 2022 16:42
Copy link
Contributor

@Rperry2174 Rperry2174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to merge now, lets follow up later with a PR to make the tables uniform (i.e. they should all look mostly the same)

@Rperry2174 Rperry2174 merged commit a79f61b into main Aug 17, 2022
@Rperry2174 Rperry2174 deleted the feature/add-common-table-component branch August 17, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants