fix(webapp): refresh data when (re)submitting query #1410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1410 +/- ##
==========================================
+ Coverage 67.86% 68.25% +0.40%
==========================================
Files 125 128 +3
Lines 4094 4170 +76
Branches 1110 1130 +20
==========================================
+ Hits 2778 2846 +68
- Misses 1311 1319 +8
Partials 5 5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
/create-server |
size-limit report 📦
|
eh-am
changed the title
|
/create-server |
1 similar comment
|
/create-server |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1406
Hitting execute/resubmitting the same query now refreshes all data (timelines and flamegraphs).
RE
QueryInput:Update comparison/diff to, when resubmitting, to reload EVERYTHING, including the opposite's timeline's and flamegraph. For example, when resubmitting the left side, it will also reload:
Which has the side effect of having your selection be "lost". Here's an illustration:
Kapture.2022-08-16.at.14.40.19.mp4
We discussed internally and it should be fine for now.