Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(flamegraph): table, buttons colors for light mode #1458

Merged
merged 1 commit into from
Sep 5, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/pyroscope-flamegraph/src/Toolbar.module.css
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@
align-items: center;
}

.navbar button {
color: var(--ps-neutral-2);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to define that somewhat globally no? Since it's clear this color applies app-wide.

}

/* Give same amount of space between all children */
.navbar > *:not(:first-child) {
margin-left: 5px;
Expand Down
5 changes: 5 additions & 0 deletions webapp/sass/common.scss
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,13 @@ tt {
font-size: 14px;
border: 1px solid var(--ps-ui-border);

thead th {
color: var(--ps-neutral-2);
}

th,
td {
color: var(--ps-neutral-2);
text-align: right;
padding: 0px 10px;

Expand Down