Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(flamegraph): table width #1466

Merged
merged 3 commits into from
Sep 6, 2022
Merged

fix(flamegraph): table width #1466

merged 3 commits into from
Sep 6, 2022

Conversation

eh-am
Copy link
Collaborator

@eh-am eh-am commented Sep 6, 2022

Same as #1463

added to the wrong element (╯°□°)╯︵ ┻━┻

@eh-am eh-am changed the title Fix/flamegraph table width fix(flamegraph): table width Sep 6, 2022
@eh-am eh-am marked this pull request as ready for review September 6, 2022 17:25
@Rperry2174
Copy link
Contributor

lol my bad I did not review very well either 😅

also:
#1465 (comment)

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 420.48 KB (0%) 8.5 s (0%) 3.9 s (+29.48% 🔺) 12.3 s
webapp/public/assets/app.css 15.67 KB (-0.02% 🔽) 314 ms (-0.02% 🔽) 0 ms (+100% 🔺) 314 ms
webapp/public/assets/styles.css 9.47 KB (0%) 190 ms (0%) 0 ms (+100% 🔺) 190 ms
packages/pyroscope-flamegraph/dist/index.js 91.8 KB (0%) 1.9 s (0%) 1.4 s (-29.02% 🔽) 3.2 s
packages/pyroscope-flamegraph/dist/index.node.js 91.65 KB (0%) 1.9 s (0%) 565 ms (-20.27% 🔽) 2.4 s
packages/pyroscope-flamegraph/dist/index.css 7.12 KB (-0.06% 🔽) 143 ms (-0.06% 🔽) 0 ms (+100% 🔺) 143 ms

@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #1466 (43e86cf) into main (d464619) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1466   +/-   ##
=======================================
  Coverage   68.66%   68.66%           
=======================================
  Files         131      131           
  Lines        4316     4316           
  Branches     1166     1166           
=======================================
  Hits         2963     2963           
  Misses       1347     1347           
  Partials        6        6           
Impacted Files Coverage Δ
...roscope-flamegraph/src/Tooltip/Tooltip.module.scss 61.54% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@Rperry2174 Rperry2174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
image

Why is there a stripe in the middle row here, but not in our tooltip on i.e. demo-dev.pyroscope.io ?

@eh-am eh-am merged commit a60f608 into main Sep 6, 2022
@eh-am eh-am deleted the fix/flamegraph-table-width branch September 6, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants