perf: optimize allocations in dictionaries #1610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
Codecov ReportBase: 66.59% // Head: 66.59% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1610 +/- ##
=======================================
Coverage 66.59% 66.59%
=======================================
Files 148 148
Lines 5030 5030
Branches 1162 1162
=======================================
Hits 3349 3349
Misses 1676 1676
Partials 5 5 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
petethepig
approved these changes
Oct 10, 2022
petethepig
reviewed
Oct 10, 2022
kolesnikovae
changed the title
kolesnikovae
commented
Oct 11, 2022
|
/create-server |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we observe high CPU time consumption of Go GC in certain cases:
Significant part of the objects are allocated at tree serialisation when node labels are encoded using dictionaries: notice that the function is called twice, on TTL interval and at memory-pressure-based eviction – in practice, it can reach ~40% of objects:
It is interesting that the second biggest consumer is
varint.NewWriterwhich allocates a tiny buffer.