Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove tmp multipart files #1678

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Conversation

kolesnikovae
Copy link
Collaborator

Currently, when ingesting a JFR or pprof profile exceeding 32MB, pyroscope server uses /tmp file system. The problem is that after parsing, files remain that are never deleted automatically (by the pyroscope server).

May fix #1665

@kolesnikovae
Copy link
Collaborator Author

/dev-build

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 485.37 KB (0%) 9.8 s (0%) 4 s (+7.04% 🔺) 13.7 s
webapp/public/assets/app.css 18.62 KB (0%) 373 ms (0%) 0 ms (+100% 🔺) 373 ms
webapp/public/assets/styles.css 9.54 KB (0%) 191 ms (0%) 0 ms (+100% 🔺) 191 ms
packages/pyroscope-flamegraph/dist/index.js 129.73 KB (0%) 2.6 s (0%) 1.7 s (-7.83% 🔽) 4.3 s
packages/pyroscope-flamegraph/dist/index.node.js 130.19 KB (0%) 2.7 s (0%) 750 ms (+0.96% 🔺) 3.4 s
packages/pyroscope-flamegraph/dist/index.css 7.88 KB (0%) 158 ms (0%) 0 ms (+100% 🔺) 158 ms

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Base: 66.59% // Head: 66.56% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (0cdedc9) compared to base (deb36ad).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1678      +/-   ##
==========================================
- Coverage   66.59%   66.56%   -0.02%     
==========================================
  Files         148      156       +8     
  Lines        5030     5274     +244     
  Branches     1162     1207      +45     
==========================================
+ Hits         3349     3510     +161     
- Misses       1676     1758      +82     
- Partials        5        6       +1     
Impacted Files Coverage Δ
webapp/javascript/services/appNames.ts 27.78% <0.00%> (-62.69%) ⬇️
webapp/javascript/ui/Tooltip.tsx 72.73% <0.00%> (-14.77%) ⬇️
webapp/javascript/util/formatDate.ts 87.33% <0.00%> (-4.22%) ⬇️
webapp/javascript/ui/Button.tsx 78.38% <0.00%> (-3.43%) ⬇️
webapp/javascript/util/updateRequests.ts 18.19% <0.00%> (-1.81%) ⬇️
...graph/src/FlameGraph/FlameGraphComponent/index.tsx 81.89% <0.00%> (-1.19%) ⬇️
webapp/javascript/redux/reducers/tracing.ts 19.45% <0.00%> (-1.16%) ⬇️
...e-flamegraph/src/FlameGraph/FlameGraphRenderer.tsx 49.10% <0.00%> (-0.90%) ⬇️
...raph/src/FlameGraph/FlameGraphComponent/Header.tsx 90.48% <0.00%> (-0.43%) ⬇️
...ages/pyroscope-flamegraph/src/SharedQueryInput.tsx 64.52% <0.00%> (-0.09%) ⬇️
... and 22 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kolesnikovae kolesnikovae merged commit 6a1b631 into main Nov 4, 2022
@kolesnikovae kolesnikovae deleted the fix/remove-tmp-multiform-parts branch November 4, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/tmp/multipart-xxxxxxxxxx files don't expire
2 participants