Resolves #165 - implemented out of space check #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
petethepig
reviewed
May 2, 2021
Codecov Report
@@ Coverage Diff @@
## main #174 +/- ##
==========================================
- Coverage 57.33% 57.03% -0.29%
==========================================
Files 72 73 +1
Lines 2896 2960 +64
==========================================
+ Hits 1660 1688 +28
- Misses 1100 1129 +29
- Partials 136 143 +7
Continue to review full report at Codecov.
|
petethepig
requested changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Space is not indefinite and running out of space may make the application doing weird behavior. To prevent that here is the implementation. It basically does a check on the data feed to see if there is enough space to store. It will also put a warning value with API response about out of space warning.