Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flamegraph: fix dropdown menu opening #1755

Merged
merged 6 commits into from
Nov 23, 2022
Merged

flamegraph: fix dropdown menu opening #1755

merged 6 commits into from
Nov 23, 2022

Conversation

pavelpashkovsky
Copy link
Contributor

@pavelpashkovsky pavelpashkovsky commented Nov 22, 2022

Brief

Changes

next step is updating flamegraph version in this PR pyroscope-io/docs#141

@github-actions
Copy link
Contributor

github-actions bot commented Nov 22, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 493.17 KB (+0.08% 🔺) 9.9 s (+0.08% 🔺) 3.6 s (-9.27% 🔽) 13.4 s
webapp/public/assets/app.css 19.63 KB (-1.79% 🔽) 393 ms (-1.79% 🔽) 0 ms (+100% 🔺) 393 ms
webapp/public/assets/styles.css 9.56 KB (0%) 192 ms (0%) 0 ms (+100% 🔺) 192 ms
packages/pyroscope-flamegraph/dist/index.js 129.82 KB (-1.11% 🔽) 2.6 s (-1.11% 🔽) 1.2 s (-24.59% 🔽) 3.8 s
packages/pyroscope-flamegraph/dist/index.node.js 130.57 KB (-1.06% 🔽) 2.7 s (-1.06% 🔽) 565 ms (-12.17% 🔽) 3.2 s
packages/pyroscope-flamegraph/dist/index.css 7.93 KB (-4.29% 🔽) 159 ms (-4.29% 🔽) 0 ms (+100% 🔺) 159 ms

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Base: 66.24% // Head: 66.27% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (deb15dd) compared to base (1dd9cbc).
Patch coverage: 80.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1755      +/-   ##
==========================================
+ Coverage   66.24%   66.27%   +0.03%     
==========================================
  Files         169      170       +1     
  Lines        5562     5561       -1     
  Branches     1261     1258       -3     
==========================================
+ Hits         3684     3685       +1     
+ Misses       1868     1866       -2     
  Partials       10       10              
Impacted Files Coverage Δ
...raphComponent/DiffLegendPaletteDropdown.module.css 61.54% <ø> (ø)
webapp/javascript/util/features.ts 95.00% <ø> (+0.27%) ⬆️
webapp/javascript/ui/Dropdown.module.scss 61.54% <25.00%> (ø)
...src/FlameGraph/FlameGraphComponent/ContextMenu.tsx 97.06% <100.00%> (+4.04%) ⬆️
.../FlameGraphComponent/DiffLegendPaletteDropdown.tsx 73.59% <100.00%> (ø)
...graph/src/FlameGraph/FlameGraphComponent/index.tsx 80.54% <100.00%> (ø)
webapp/javascript/components/Sidebar.tsx 86.67% <100.00%> (ø)
webapp/javascript/ui/Menu.tsx 100.00% <100.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pavelpashkovsky
Copy link
Contributor Author

/create-server

@pavelpashkovsky pavelpashkovsky changed the title flamegraph: fix dropdown menu opening [WIP] flamegraph: fix dropdown menu opening Nov 23, 2022
@pavelpashkovsky pavelpashkovsky marked this pull request as ready for review November 23, 2022 12:41
Comment on lines -28 to -31
.diffPaletteDropdown ::global(.rc-menu-item) {
display: flex;
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed bc unused

@pavelpashkovsky
Copy link
Contributor Author

/create-server

@eh-am eh-am merged commit 0b1acef into main Nov 23, 2022
@eh-am eh-am deleted the flamegraph-menu-fix branch November 23, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Context menu on Flamegraph throws "same key" error
3 participants