Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable inlining for golang example #211

Merged
merged 1 commit into from
May 24, 2021
Merged

Conversation

kolesnikovae
Copy link
Collaborator

Otherwise, work function is inlined (go1.16.4 windows/amd64) and flamegraph becomes slightly less demonstrative.

Inlined:
image

With go:noinline:
image

Otherwise, work function is inlined (go1.16.4 windows/amd64)
and flamegraph becomes slightly less demonstrative.
@github-actions github-actions bot requested review from petethepig and Rperry2174 May 24, 2021 16:38
@codecov
Copy link

codecov bot commented May 24, 2021

Codecov Report

Merging #211 (2900c81) into main (b727bff) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #211   +/-   ##
=======================================
  Coverage   57.23%   57.23%           
=======================================
  Files          73       73           
  Lines        2943     2943           
=======================================
  Hits         1684     1684           
  Misses       1114     1114           
  Partials      145      145           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99d76c2...2900c81. Read the comment docs.

Copy link
Member

@petethepig petethepig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that's an interesting find, merging!

@petethepig petethepig merged commit 80a334a into main May 24, 2021
@petethepig petethepig deleted the golang-example-noinline branch May 24, 2021 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants