Document dotnet magic denominator #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolesnikovae
added
documentation
petethepig
approved these changes
Jun 22, 2021
korniltsev
pushed a commit
that referenced
this pull request
Jul 18, 2023
* Top table * Col width * Initial sort by * Match top table height with flamegraph height * Cleanup * Yarn prettier * Types * useCallback so topTable does not keep rendering on tooltip hover * Get units * Extraction * Min width to show top table * Padding right * Selected view * Move top table to container * Prettier * Fix undefined * react-table * Styling * Update tests and add tests for top table * FlameGraphContainer tests for options * Only add collapse container to explore * Background container instead of collapse * Update colors * Self review * Updates after merge * Fix for backend tests * Update how toptable/flamegraph/both is shown * Update query -> search * Default view selected * Use df instead of levels for top table * Search and selected view updates * Reverse both to flamegraph click to reset search based on discussion * Optimise prop * Remove unwanted scroll to top
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to how dotnet profiler is different comparing to other spies, there is an obscure transforming of reported CPU time, which may be misleading. This PR is aimed to shed light on why it takes place.