Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds the compactor for the all target #2875

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Conversation

cyriltovena
Copy link
Contributor

Wasn't there at first cause it was experimental but it seems to be doing good so let's add it to all target.

Fixes #2863

@cyriltovena cyriltovena requested a review from a team as a code owner December 21, 2023 12:51
Copy link
Collaborator

@kolesnikovae kolesnikovae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit ba25f23 into main Dec 21, 2023
19 checks passed
@cyriltovena cyriltovena deleted the feat/compactor-all branch December 21, 2023 13:05
simonswine added a commit that referenced this pull request Jul 31, 2024
This apparently was missed in #2875

```
ts=2024-07-31T14:22:52.491454333Z caller=compactor.go:646 level=error component=compactor component=compactor msg="failed to compact user blocks" tenant=anonymous err="mkdir data-compactor: permission denied"
```
simonswine added a commit that referenced this pull request Jul 31, 2024
This apparently was missed in #2875

```
ts=2024-07-31T14:22:52.491454333Z caller=compactor.go:646 level=error component=compactor component=compactor msg="failed to compact user blocks" tenant=anonymous err="mkdir data-compactor: permission denied"
```
aleks-p pushed a commit that referenced this pull request Jul 31, 2024
This apparently was missed in #2875

```
ts=2024-07-31T14:22:52.491454333Z caller=compactor.go:646 level=error component=compactor component=compactor msg="failed to compact user blocks" tenant=anonymous err="mkdir data-compactor: permission denied"
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compactor is not run when using target all
2 participants