experiment: add experimental metrics exporter #2899
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolesnikovae
commented
Jan 10, 2024
Comment on lines
+152
to
+174
| func (v *TimerVec) createPprofLabels(lvs []string) pprof.LabelSet { | ||
| k := v.labels.Copy() | ||
| if len(lvs) > 0 { | ||
| for i, lv := range lvs { | ||
| k[i].Value = lv | ||
| } | ||
| } | ||
| sort.Sort(k) | ||
| var b bytes.Buffer | ||
| b.WriteString(pprofMetricLabelPrefix) | ||
| b.WriteByte('{') | ||
| for i, l := range k { | ||
| if i > 0 { | ||
| b.WriteByte(',') | ||
| b.WriteByte(' ') | ||
| } | ||
| b.WriteString(l.Name) | ||
| b.WriteByte('=') | ||
| b.WriteString(strconv.Quote(l.Value)) | ||
| } | ||
| b.WriteByte('}') | ||
| return pprof.Labels(b.String(), "") | ||
| } |
There was a problem hiding this comment.
Ineffective, but very simple method. Note that we should not mix metric labels with pprof labels
Comment on lines
+325
to
+343
| for _, series := range req.Series { | ||
| for _, sample := range series.Samples { | ||
| mr := exporter.WriteRequest{ | ||
| Timestamp: time.Unix(0, sample.Profile.TimeNanos).UnixMilli(), | ||
| } | ||
| pprof.ExtractMetrics(sample.Profile.Profile, func(labels labels.Labels, v int64) { | ||
| mr.TimeSeries = append(mr.TimeSeries, exporter.TimeSeries{Labels: labels, Value: float64(v)}) | ||
| }) | ||
|
|
||
| if len(mr.TimeSeries) > 0 { | ||
| go func() { | ||
| if sendErr := d.exporter.Send(context.Background(), &mr); sendErr != nil { | ||
| _ = d.logger.Log("msg", "failed to push metrics", "err", sendErr) | ||
| } | ||
| }() | ||
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
For PoC purposes only. Prometheus remote write protocol requires strict order by time within series, therefore we'll likely need a dedicated component that will handle proxying to receiver
| if err := buf.Marshal(p); err != nil { | ||
| return err | ||
| } | ||
| return e.client.Store(ctx, snappy.Encode(nil, buf.Bytes()), 0) |
There was a problem hiding this comment.
Prometheus also provides a "fat" remote storage that uses WAL. We should probably consider this option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A PoC of derived metrics. See #2908 for details