feat: flamegraph node time-series #2961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolesnikovae
changed the title
kolesnikovae
commented
Jan 26, 2024
Comment on lines
+77
to
+80
| // Stack trace of the call site. Root at call_site[0]. | ||
| // Only stack traces having the prefix provided will be selected. | ||
| // If empty, the filter is ignored. | ||
| repeated Location call_site = 1; |
There was a problem hiding this comment.
Renamed it one more time. As the API it not used anywhere, it should not be an issue
There was a problem hiding this comment.
cc @bryanhuhta for the hackathon this is what we're going to use in all API when clicking on a function to reduce size of pprof and zoom on a single function.
kolesnikovae
commented
Jan 26, 2024
Comment on lines
+10
to
+23
| // CallSiteValues represents statistics associated with a call tree node. | ||
| type CallSiteValues struct { | ||
| // Flat is the sum of sample values directly attributed to the node. | ||
| Flat uint64 | ||
| // Total is the total sum of sample values attributed to the node and | ||
| // its descendants. | ||
| Total uint64 | ||
| // LocationFlat is the sum of sample values directly attributed to the | ||
| // node location, irrespectively of the call chain. | ||
| LocationFlat uint64 | ||
| // LocationTotal is the total sum of sample values attributed to the | ||
| // node location and its descendants, irrespectively of the call chain. | ||
| LocationTotal uint64 | ||
| } |
There was a problem hiding this comment.
Please note that at the moment only Total is actually used. We can return all, but we need some toggle in UI that switches between them. Otherwise, the timeline view becomes too busy (especially, if group by is used)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2228