-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental: Adds a Github Integration to fetch profiled code #2965
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be a killer feature once it gets some polish 🥇
Great idea! Will we need some doc to help people configure this? |
…eat/github-api-ui
@knylander-grafana Eventually we will! Right now we need to focus on polish and some integration details. At this point we have a pretty good idea how it will all work, but let's delay getting docs started until we do more polish and can be more confident on how this feature should be configured by the users. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! A few small remarks but nothing blocking.
This adds a set of API that allows users to connect their Pyroscope to Github and fetch profiling code for future mapping with profiling data.
Right now this is a big focus on Github and go but in the future we can expand to other VCS or language.
For go the API allows to fetch code for go modules (vendor or not), go standard library and main application code.
The API requires to provide:
The PR contains a html page for testing purpose and will be removed prior merging.
Remaining Tasks
cc @bryanhuhta @grafakus