Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples: update rideshare examples #2990

Merged
merged 3 commits into from
Feb 9, 2024
Merged

examples: update rideshare examples #2990

merged 3 commits into from
Feb 9, 2024

Conversation

korniltsev
Copy link
Collaborator

@korniltsev korniltsev commented Feb 6, 2024 •
edited
Loading

  • add RIDESHARE_LISTEN_PORT env variable
  • update loadgen to accept urls instead of hostnames
  • split makefile target to build examples concurrently with -j

this is to allow to run multiple rideshare examples in the same network namespace ( pod)

@korniltsev korniltsev requested a review from a team as a code owner February 6, 2024 11:18
kolesnikovae
kolesnikovae approved these changes Feb 9, 2024
View reviewed changes
Copy link
Collaborator

@kolesnikovae kolesnikovae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@korniltsev korniltsev merged commit 9baa913 into main Feb 9, 2024
19 checks passed
@korniltsev korniltsev deleted the rideshare-examples-loadgen-changes branch February 9, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolesnikovae kolesnikovae kolesnikovae approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@korniltsev @kolesnikovae