Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid php-fpm host #2995

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Fix invalid php-fpm host #2995

merged 1 commit into from
Feb 21, 2024

Conversation

cv65kr
Copy link
Contributor

@cv65kr cv65kr commented Feb 9, 2024

According to docker-compose file host for php-fpm should be php instead of pyroscope_php-fpm.

@cv65kr cv65kr requested a review from a team as a code owner February 9, 2024 10:20
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the fix

@simonswine simonswine merged commit abcea72 into grafana:main Feb 21, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants