Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Updates to correct minor issues in intro doc #3089

Merged

Conversation

knylander-grafana
Copy link
Contributor

@knylander-grafana knylander-grafana commented Mar 8, 2024

This PR corrects some minor issues in the introductory docs. Repeating some of the updates made to doc from https://github.com/grafana/pyroscope-squad/issues/122

@knylander-grafana knylander-grafana added the type/docs Improvements for doc docs. Used by Docs team for project management label Mar 8, 2024
@knylander-grafana knylander-grafana self-assigned this Mar 8, 2024
@knylander-grafana knylander-grafana requested review from a team as code owners March 8, 2024 07:51
@knylander-grafana
Copy link
Contributor Author

@jdbaldry How do I update the validator version for Pyroscope repository? This PR has an error message from doc-validator to use an older format for links.

Copy link
Contributor

@Rperry2174 Rperry2174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@jdbaldry
Copy link
Member

@jdbaldry How do I update the validator version for Pyroscope repository? This PR has an error message from doc-validator to use an older format for links.

https://github.com/grafana/pyroscope/blob/main/.github/workflows/test.yml#L66 is the line to change.

v4.1.1 is the latest release (https://github.com/grafana/technical-documentation/releases)

@knylander-grafana knylander-grafana merged commit 58f4cab into grafana:main Mar 12, 2024
16 of 17 checks passed
@knylander-grafana knylander-grafana deleted the ps-122-minor-intro-doc-fixes branch March 12, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Improvements for doc docs. Used by Docs team for project management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants