Skip to content

Conversation

@simonswine
Copy link
Contributor

@simonswine simonswine commented Apr 4, 2024

http2: close connections when receiving too many headers

Maintaining HPACK state requires that we parse and process all HEADERS and CONTINUATION frames on a connection. When a request's headers exceed MaxHeaderBytes, we don't allocate memory to store the excess headers but we do parse them. This permits an attacker to cause an HTTP/2 endpoint to read arbitrary amounts of header data, all associated with a request which is going to be rejected. These headers can include Huffman-encoded data which is significantly more expensive for the receiver to decode than for an attacker to send.

Set a limit on the amount of excess header frames we will process before closing a connection.

Thanks to Bartek Nowotarski (https://nowotarski.info/) for reporting this issue.

This is CVE-2023-45288 and Go issue https://go.dev/issue/65051.

https://go.dev/doc/devel/release#go1.21.minor

@simonswine simonswine marked this pull request as ready for review April 4, 2024 08:01
@simonswine simonswine requested a review from a team as a code owner April 4, 2024 08:01
@simonswine simonswine enabled auto-merge (squash) April 4, 2024 08:02
@simonswine simonswine merged commit e046dcd into grafana:main Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants