Example and docs for .NET span profiles #3224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
54
to
57
| .AddProcessor(new PyroscopeSpanProcessor.Builder() | ||
| .WithRootSpanOnly(true) | ||
| .Build()); | ||
| }); |
There was a problem hiding this comment.
What do you think about removing the WithRootSpanOnly option? It should be true by default, and, honestly, I'm not very sure if we do want to make it configurable. We left this in other integrations to avoid breaking changes
There was a problem hiding this comment.
It is true by default, I added it here so that it is more visible. I don't have a strong opinion about it, I will remove the configuration option for now and add it back in the future if needed.
kolesnikovae
approved these changes
Apr 17, 2024
|
@knylander-grafana could you take a look at the added doc here? Also, we probably need to update https://grafana.com/docs/grafana/latest/datasources/tempo/configure-tempo-data-source/#trace-to-profiles but it might make sense to remove the list of languages there and rely on the already linked page for this. |
docs/sources/configure-client/trace-span-profiles/dotnet-span-profiles.md
Show resolved
Hide resolved
docs/sources/configure-client/trace-span-profiles/dotnet-span-profiles.md
Outdated
Show resolved
Hide resolved
docs/sources/configure-client/trace-span-profiles/dotnet-span-profiles.md
Outdated
Show resolved
Hide resolved
docs/sources/configure-client/trace-span-profiles/dotnet-span-profiles.md
Outdated
Show resolved
Hide resolved
docs/sources/configure-client/trace-span-profiles/dotnet-span-profiles.md
Outdated
Show resolved
Hide resolved
docs/sources/configure-client/trace-span-profiles/dotnet-span-profiles.md
Outdated
Show resolved
Hide resolved
docs/sources/configure-client/trace-span-profiles/java-span-profiles.md
Outdated
Show resolved
Hide resolved
docs/sources/configure-client/trace-span-profiles/ruby-span-profiles.md
Outdated
Show resolved
Hide resolved
docs/sources/configure-client/trace-span-profiles/dotnet-span-profiles.md
Outdated
Show resolved
Hide resolved
docs/sources/configure-client/trace-span-profiles/dotnet-span-profiles.md
Outdated
Show resolved
Hide resolved
docs/sources/configure-client/trace-span-profiles/ruby-span-profiles.md
Outdated
Show resolved
Hide resolved
docs/sources/configure-client/trace-span-profiles/java-span-profiles.md
Outdated
Show resolved
Hide resolved
3 tasks
knylander-grafana
approved these changes
Apr 19, 2024
knylander-grafana
added
type/docs
|
This PR must be merged before a backport PR will be created. |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 19, 2024
* Enable span profiles for the .NET ride share example app * Add docs for .NET span profiles * Add missing file * Bump Pyroscope.OpenTelemetry to 0.2.0 * Update docs to reflect library update * Apply suggestions from code review * Apply suggestions from code review * Unify span profiling doc introduction across languages --------- Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com> (cherry picked from commit 635b42c)
This comment was marked as outdated.
This comment was marked as outdated.
aleks-p
added a commit
that referenced
this pull request
Apr 19, 2024
* Enable span profiles for the .NET ride share example app * Add docs for .NET span profiles * Add missing file * Bump Pyroscope.OpenTelemetry to 0.2.0 * Update docs to reflect library update * Apply suggestions from code review * Apply suggestions from code review * Unify span profiling doc introduction across languages --------- Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com> (cherry picked from commit 635b42c) Co-authored-by: Aleksandar Petrov <8142643+aleks-p@users.noreply.github.com>
Merged
3 tasks
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
examples/tracing/tempo, to demonstrate span profiles in .NET