Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix debug info attribute #3258

Merged

Conversation

simonswine
Copy link
Contributor

@simonswine simonswine commented Apr 26, 2024

This is something that would be nice to test, but I guess we don't want to get into circular dependecies with alloy 😢

I also migrated the targets to be fully structured, so they display better than:

image

This is something that would be nice to test, but I guess we don't want
to get into circular dependecies with alloy 😢
@simonswine simonswine marked this pull request as ready for review April 26, 2024 15:50
@simonswine simonswine requested a review from korniltsev as a code owner April 26, 2024 15:50
Copy link
Contributor

@bryanhuhta bryanhuhta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@simonswine simonswine merged commit 8575ca6 into grafana:main Apr 26, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants