Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/grafana example #331

Merged
merged 6 commits into from
Aug 11, 2021
Merged

Conversation

eh-am
Copy link
Collaborator

@eh-am eh-am commented Aug 10, 2021

As per our conversation, a docker-compose example with grafana + prometheus + pyroscope

Replaced the default grafana dashboard for a custom one, we can make it pretty/add more instructions in the future.

Screenshot from 2021-08-10 16-38-15

So I added 3 dashboards:

  • Pyroscope Server (Prometheus)
  • Pyroscope Server (Pyroscope)
  • Simple Go App (Pyroscope

Pyroscope Server (Prometheus)

The same one from /bottleneck minus the debug info.

Once we publish this dashboard to grafana (next part of the plan), this can be updated to refer to the version in the grafana "store"
Screenshot from 2021-08-10 16-38-48

Simple Go App (Pyroscope)

Screenshot from 2021-08-10 16-39-12

I don't know what's relevant here so I just displayed everything.

QUESTION: Is it interesting to expose more example applications too?

Pyroscope Server (Pyroscope)

This is for when people feel the Simple Go App is not realistic enough.
Screenshot from 2021-08-10 16-39-01

I don't know what's relevant here so I just displayed everything.

@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #331 (e39da20) into main (b6b3342) will increase coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #331      +/-   ##
==========================================
+ Coverage   53.85%   53.97%   +0.13%     
==========================================
  Files         101      102       +1     
  Lines        4511     4777     +266     
==========================================
+ Hits         2429     2578     +149     
- Misses       1846     1960     +114     
- Partials      236      239       +3     
Impacted Files Coverage Δ
pkg/storage/storage.go 57.47% <100.00%> (-5.85%) ⬇️
scripts/decode-resp/decode.go 61.12% <0.00%> (-38.88%) ⬇️
pkg/server/render.go 42.31% <0.00%> (-35.87%) ⬇️
pkg/server/handler.go 0.44% <0.00%> (-<0.01%) ⬇️
pkg/server/labels.go 0.00% <0.00%> (ø)
pkg/storage/tree/flamebearer.go 100.00% <0.00%> (ø)
pkg/storage/tree/treediff.go 98.50% <0.00%> (ø)
pkg/storage/tree/tree.go 82.98% <0.00%> (+0.38%) ⬆️
pkg/server/controller.go 31.80% <0.00%> (+0.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6b3342...e39da20. Read the comment docs.

@petethepig petethepig merged commit bc34086 into grafana:main Aug 11, 2021
korniltsev pushed a commit that referenced this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants