chore: support dots in label names #3335
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're currently using prometheus data model for labels (including those that are set as pprof tags) for consistency with other products:
Although we can not easily loosen the requirement, I'm not very sure if discarding profiles that violate it is the best strategy.
There is ongoing work on support for UTF-8 labels in Prometheus:
prometheus/prometheus#13095:
Until the support is fully implemented, I propose to do the same in Pyroscope – convert
.
to_
in label names to make interoperability easier. Theoretically, we could replace any disallowed characters, but that leads to ambiguity in certain cases and may confuse users.