Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error handling in filterProfiles #3338

Conversation

simonswine
Copy link
Contributor

@simonswine simonswine commented Jun 5, 2024

We seem to ignore errors during the filterProfiles deduplication, at the stage when we received the decisions if something should be kept or not.

@simonswine simonswine marked this pull request as ready for review June 5, 2024 10:29
@simonswine simonswine requested a review from a team as a code owner June 5, 2024 10:29
Copy link
Collaborator

@kolesnikovae kolesnikovae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Nice catch!

@simonswine simonswine merged commit a839566 into grafana:main Jun 5, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants