-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update outdated java span profile information #3339
Conversation
This PR must be merged before a backport PR will be created. |
docs/sources/configure-client/trace-span-profiles/java-span-profiles.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small question, but otherwise, looks good. Thank you for updating the docs!
docs/sources/configure-client/trace-span-profiles/java-span-profiles.md
Outdated
Show resolved
Hide resolved
…ofiles.md Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
* Update outdated java span profile information * Remove first person and uppercase docker * Update docs/sources/configure-client/trace-span-profiles/java-span-profiles.md Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com> --------- Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com> (cherry picked from commit fa05d6b)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-3339-to-release/v1.6 origin/release/v1.6
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x fa05d6bd59c1db5b09ae5e211723ad7d2fb09b70 When the conflicts are resolved, stage and commit the changes:
If you have the GitHub CLI installed: # Push the branch to GitHub:
git push --set-upstream origin backport-3339-to-release/v1.6
# Create the PR body template
PR_BODY=$(gh pr view 3339 --json body --template 'Backport fa05d6bd59c1db5b09ae5e211723ad7d2fb09b70 from #3339{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title '[release/v1.6] Update outdated java span profile information' --body-file - --label 'type/docs' --label 'backport' --base release/v1.6 --milestone release/v1.6 --web Or, if you don't have the GitHub CLI installed (we recommend you install it!): # Push the branch to GitHub:
git push --set-upstream origin backport-3339-to-release/v1.6
# Create a pull request where the `base` branch is `release/v1.6` and the `compare`/`head` branch is `backport-3339-to-release/v1.6`.
# Remove the local backport branch
git switch main
git branch -D backport-3339-to-release/v1.6 |
* Update outdated java span profile information * Remove first person and uppercase docker * Update docs/sources/configure-client/trace-span-profiles/java-span-profiles.md Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com> --------- Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com> (cherry picked from commit fa05d6b) Co-authored-by: Christian Simon <simon@swine.de>
I had been going through those docs with one of our customers, I think the code blocks are very confusing and I think settings should be set using environment variables.
I do hope I did not misunderstand anything.