Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Only mount UI index at known paths #3362

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

simonswine
Copy link
Contributor

This will ensure that the backend reports 404s for wrong paths.

@simonswine simonswine force-pushed the 20240619_mount-ui-only-root branch 2 times, most recently from cc8be70 to 7d9eac8 Compare June 19, 2024 11:06
This will ensure that the backend reports 404s for wrong paths.
@simonswine simonswine force-pushed the 20240619_mount-ui-only-root branch from 7d9eac8 to 5e67405 Compare June 19, 2024 11:10
@simonswine simonswine changed the title Only mount UI index at root UI: Only mount UI index at root Jun 19, 2024
@simonswine simonswine changed the title UI: Only mount UI index at root UI: Only mount UI index at known pathsoot Jun 19, 2024
@simonswine simonswine changed the title UI: Only mount UI index at known pathsoot UI: Only mount UI index at known paths Jun 19, 2024
@simonswine simonswine marked this pull request as ready for review June 19, 2024 11:24
@simonswine simonswine requested a review from a team as a code owner June 19, 2024 11:24
Copy link
Collaborator

@kolesnikovae kolesnikovae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonswine simonswine merged commit ce3f59b into grafana:main Jun 21, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants