-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(distributor): Relabel profiles at ingest #3369
Merged
simonswine
merged 2 commits into
grafana:main
from
simonswine:20240606_relabel_at_ingest
Jun 26, 2024
Merged
feat(distributor): Relabel profiles at ingest #3369
simonswine
merged 2 commits into
grafana:main
from
simonswine:20240606_relabel_at_ingest
Jun 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
This is an important operational tool: It allows us to deal with problems in the ingested profile labels. The relabeling rules cover both series label and also sample labes. By default we supply relabeling rules, which do remove the godeltaprof_ prefix from profiles generated by pyroscope-go.
simonswine
force-pushed
the
20240606_relabel_at_ingest
branch
from
June 21, 2024 09:37
68d2a20
to
9d5b6c0
Compare
simonswine
changed the title
Relabel profiles at ingest
feat: Relabel profiles at ingest
Jun 21, 2024
simonswine
changed the title
feat: Relabel profiles at ingest
feat(distributor): Relabel profiles at ingest
Jun 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! I added a few comments
I have also added the most common test cases I could think of.
kolesnikovae
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an important operational tool: It allows us to deal with problems in the ingested profile labels.
The relabeling rules cover both series label and also sample labes.
By default we supply relabeling rules, which do remove the
godeltaprof_
prefix from profiles generated by pyroscope-go.