Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix template issue with older Helm versions #3379

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Conversation

aleks-p
Copy link
Contributor

@aleks-p aleks-p commented Jun 21, 2024

Fixes #3004 by changing the template in question. Verified with Helm 3.8.1 and 3.15.2.

@aleks-p aleks-p requested a review from a team as a code owner June 21, 2024 14:35
Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aleks-p aleks-p changed the title Fix template issue with older Helm versions chore: Fix template issue with older Helm versions Jun 21, 2024
@aleks-p aleks-p merged commit 1a735a9 into main Jun 21, 2024
16 checks passed
@aleks-p aleks-p deleted the fix/helm-3.8.1 branch June 21, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail to install simple pyroscope using helm chart
2 participants