-
Notifications
You must be signed in to change notification settings - Fork 649
Add a POST handler for render-diff
#338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #338 +/- ##
==========================================
+ Coverage 53.93% 54.47% +0.55%
==========================================
Files 102 102
Lines 4781 4834 +53
==========================================
+ Hits 2578 2633 +55
+ Misses 1964 1951 -13
- Partials 239 250 +11
Continue to review full report at Codecov.
|
0b6f919
to
b739c52
Compare
Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
53c18f1
to
137d76a
Compare
Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
9ba79d4
to
131653f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I've left a couple of notes, please take a look :)
… handler Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
bfb2b15
to
9c56b06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, merging
Refactor gzip reading/writing
This is because the mapping ID is set to 0 on the locations. It also adds an uncompressed profile that should be solved by #338.
Added a POST handler for
/render-diff
Fixes #321
Verification
Verified the endpoint using Postman -
TODO -