-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: optimize tree processing #3386
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pkg/phlaredb/symdb/resolver.go
kolesnikovae
force-pushed
the
perf/optimize-tree-processing
branch
from
June 25, 2024 08:50
34dfc61
to
0458bf1
Compare
kolesnikovae
commented
Jun 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original fixture has random sample values, which leads to integer overflow
kolesnikovae
changed the title
WIP: perf: optimize tree processing
perf: optimize tree processing
Jun 25, 2024
kolesnikovae
added
the
performance
If there's anything we have to be really good at it's this
label
Jun 25, 2024
kolesnikovae
force-pushed
the
perf/optimize-tree-processing
branch
from
June 25, 2024 14:59
76086bf
to
07b8e32
Compare
petethepig
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome. Let's try it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR optimizes the way samples are aggregated and symbolized:
int64
) to avoid allocations caused by the interface conversion.Benchmark of the
SelectMergeByStacktraces
query on the real data set that causes performance issues in the current implementation (~1K profiles, ~10K samples each):Most of the allocations are made in parquet decoding and reconstruction of the symbolic information (locations, functions, mappings, and strings). This is addressed in #3138.
This is quite close to the synthetic benchmarks we have:
Note that the optimisations mostly concern large data sets (significantly bigger than our
ResolveTree_Big
) and some of them are not used in the case when themax nodes
limit is not specified (defaults to 16K), or is too big, as this would be inefficient because of the increased memory consumption. Therefore, e.g.,Resolver_ResolveTree_Big/0
(no truncation) does not perform significantly better.