Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

profiles parquet encoding: fix profile column count #3420

Merged
merged 1 commit into from
Jul 15, 2024
Merged

profiles parquet encoding: fix profile column count #3420

merged 1 commit into from
Jul 15, 2024

Conversation

korniltsev
Copy link
Collaborator

noticed last columns appends are allocating

image

@korniltsev korniltsev requested a review from a team as a code owner July 12, 2024 18:08
aleks-p
aleks-p approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@aleks-p aleks-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a great find!

@kolesnikovae kolesnikovae merged commit dbc8af1 into main Jul 15, 2024
18 checks passed
@kolesnikovae kolesnikovae deleted the korniltsev/fix_profile_col_count branch July 15, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleks-p aleks-p aleks-p approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@korniltsev @aleks-p @kolesnikovae