Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adds grafana to all examples #3431

Merged
merged 4 commits into from
Jul 24, 2024
Merged

docs: adds grafana to all examples #3431

merged 4 commits into from
Jul 24, 2024

Conversation

petethepig
Copy link
Member

This adds grafana with the new explore-profiles plugin to each example.

@petethepig petethepig self-assigned this Jul 17, 2024
@petethepig petethepig requested a review from a team as a code owner July 17, 2024 00:47
Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Found a few problems, worth fixing.

examples/golang-pgo/docker-compose.yml Show resolved Hide resolved
@@ -1,15 +1,23 @@
version: "3"
version: '3'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure when that changed but I get this for all files:

docker-compose up -d
WARN[0000] /Users/christian/git/github.com/grafana/pyroscope/examples/grafana-agent-auto-instrumentation/java/docker-compose.yml: `version` is obsolete

 docker-compose --version
Docker Compose version v2.27.3

petethepig and others added 2 commits July 17, 2024 09:28
Co-authored-by: Christian Simon <simon@swine.de>
…-compose.yml

Co-authored-by: Christian Simon <simon@swine.de>
@knylander-grafana knylander-grafana added the type/docs Improvements for doc docs. Used by Docs team for project management label Jul 17, 2024
…e.yml

Co-authored-by: Christian Simon <simon@swine.de>
@simonswine simonswine merged commit df6e58c into main Jul 24, 2024
18 checks passed
@simonswine simonswine deleted the updates-examples branch July 24, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Improvements for doc docs. Used by Docs team for project management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants