docs: Link to supported languages #3432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonswine
added
the
type/docs
simonswine
commented
Jul 17, 2024
README.md
Outdated
| * [x] .NET | ||
| * [x] PHP (via `phpspy`) | ||
| * [x] Node | ||
| ## [Supported Languages](https://grafana.com/docs/pyroscope/latest/configure-client/) |
There was a problem hiding this comment.
I was in two minds if this link would even be better:
There was a problem hiding this comment.
We could do both. We could have a subsection under this header that links to support profiles types.
bryanhuhta
approved these changes
Jul 17, 2024
README.md
Outdated
| * [x] .NET | ||
| * [x] PHP (via `phpspy`) | ||
| * [x] Node | ||
| ## [Supported Languages](https://grafana.com/docs/pyroscope/latest/configure-client/) |
There was a problem hiding this comment.
We could do both. We could have a subsection under this header that links to support profiles types.
knylander-grafana
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think is better to link to docs, in order to stay up-to-date.