Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Fix broken links #3440

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

knylander-grafana
Copy link
Contributor

Fix broken links in the docs.

Fixes: #3439

@knylander-grafana knylander-grafana added the type/docs Improvements for doc docs. Used by Docs team for project management label Jul 22, 2024
@knylander-grafana knylander-grafana self-assigned this Jul 22, 2024
@knylander-grafana knylander-grafana requested review from a team as code owners July 22, 2024 19:19
@knylander-grafana knylander-grafana added the backport release/v1.6 This label will backport a merged PR to the release/v1.6 branch label Jul 22, 2024
Copy link
Contributor

This PR must be merged before a backport PR will be created.

@knylander-grafana knylander-grafana merged commit 1c3ce19 into grafana:main Jul 23, 2024
18 checks passed
@knylander-grafana knylander-grafana deleted the 3439-fix-404s-doc branch July 23, 2024 13:34
github-actions bot pushed a commit that referenced this pull request Jul 23, 2024
(cherry picked from commit 1c3ce19)
Copy link
Contributor

The backport to release/v1.6 failed:

Validation Failed: "Could not resolve to a node with the global id of 'T_kwDOAG3Mbc4AczmP'."

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-3440-to-release/v1.6 origin/release/v1.6
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 1c3ce19c023aa51fbf02c0c06b100526aefe1562

When the conflicts are resolved, stage and commit the changes:

git add . && git cherry-pick --continue

If you have the GitHub CLI installed:

# Push the branch to GitHub:
git push --set-upstream origin backport-3440-to-release/v1.6
# Create the PR body template
PR_BODY=$(gh pr view 3440 --json body --template 'Backport 1c3ce19c023aa51fbf02c0c06b100526aefe1562 from #3440{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title '[release/v1.6] [DOC] Fix broken links' --body-file - --label 'type/docs' --label 'backport' --base release/v1.6 --milestone release/v1.6 --web

Or, if you don't have the GitHub CLI installed (we recommend you install it!):

# Push the branch to GitHub:
git push --set-upstream origin backport-3440-to-release/v1.6

# Create a pull request where the `base` branch is `release/v1.6` and the `compare`/`head` branch is `backport-3440-to-release/v1.6`.

# Remove the local backport branch
git switch main
git branch -D backport-3440-to-release/v1.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release/v1.6 This label will backport a merged PR to the release/v1.6 branch backport-failed type/docs Improvements for doc docs. Used by Docs team for project management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Fix 404s in Pyroscope doc
2 participants