Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Fix broken links from doc 404 report #3489

Conversation

knylander-grafana
Copy link
Contributor

Fix the broken links from the docs 404 report.

Fixes #3488

@knylander-grafana knylander-grafana added the type/docs Improvements for doc docs. Used by Docs team for project management label Aug 15, 2024
@knylander-grafana knylander-grafana self-assigned this Aug 15, 2024
@knylander-grafana knylander-grafana requested review from a team as code owners August 15, 2024 21:23
@knylander-grafana knylander-grafana added the backport release/v1.7 This label will backport a merged PR to the release/v1.7 branch label Aug 15, 2024
Copy link
Contributor

This PR must be merged before a backport PR will be created.

Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knylander-grafana knylander-grafana merged commit 3d63809 into grafana:main Aug 16, 2024
20 checks passed
@knylander-grafana knylander-grafana deleted the fix-broken-links-pyro-aug-2024 branch August 16, 2024 17:27
github-actions bot pushed a commit that referenced this pull request Aug 16, 2024
Copy link
Contributor

The backport to release/v1.7 failed:

Validation Failed: "Could not resolve to a node with the global id of 'T_kwDOAG3Mbc4AczmP'."

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-3489-to-release/v1.7 origin/release/v1.7
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 3d638098a3face9cdc9b9f833231e4718d428275

When the conflicts are resolved, stage and commit the changes:

git add . && git cherry-pick --continue

If you have the GitHub CLI installed:

# Push the branch to GitHub:
git push --set-upstream origin backport-3489-to-release/v1.7
# Create the PR body template
PR_BODY=$(gh pr view 3489 --json body --template 'Backport 3d638098a3face9cdc9b9f833231e4718d428275 from #3489{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title '[release/v1.7] [DOC] Fix broken links from doc 404 report' --body-file - --label 'type/docs' --label 'backport' --base release/v1.7 --milestone release/v1.7 --web

Or, if you don't have the GitHub CLI installed (we recommend you install it!):

# Push the branch to GitHub:
git push --set-upstream origin backport-3489-to-release/v1.7

# Create a pull request where the `base` branch is `release/v1.7` and the `compare`/`head` branch is `backport-3489-to-release/v1.7`.

# Remove the local backport branch
git switch main
git branch -D backport-3489-to-release/v1.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release/v1.7 This label will backport a merged PR to the release/v1.7 branch backport-failed type/docs Improvements for doc docs. Used by Docs team for project management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Fix 404s in Pyroscope doc
2 participants