Build profilecli and pyroscope separately #3496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanhuhta
commented
Aug 16, 2024
| @@ -77,10 +77,15 @@ build: frontend/build go/bin ## Do a production build (requiring the frontend bu | |||
| build-dev: ## Do a dev build (without requiring the frontend) | |||
| $(MAKE) EMBEDASSETS="" go/bin | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Just whitespace formatting
| @@ -180,7 +198,7 @@ define deploy | |||
| --set pyroscope.podAnnotations."profiles\.grafana\.com\/goroutine\.port_name"=http-metrics \ | |||
| --set pyroscope.extraEnvVars.JAEGER_AGENT_HOST=jaeger.monitoring.svc.cluster.local. \ | |||
| --set pyroscope.extraArgs."pyroscopedb\.max-block-duration"=5m | |||
| endef | |||
| endef | |||
There was a problem hiding this comment.
More whitespace formatting
korniltsev
approved these changes
Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use a local debug binary of Pyroscope when testing various changes locally. Right now, the only way to get a debug binary of Pyroscope is to use
which builds both
profilecliandpyroscope. It's a minor annoyance to have to wait forprofileclito get built every time. This creates two separate rules to build Pyroscope orprofilecli.