Enhance commit retrieval with branch & tag prefix support #3518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
marcsanmi
force-pushed
the
prefix-git-ref-with-tags-head
branch
from
ffe2521 to
1c36f1b
Compare
marcsanmi
force-pushed
the
prefix-git-ref-with-tags-head
branch
from
bf7d9b8 to
dd0342a
Compare
bryanhuhta
approved these changes
Aug 27, 2024
Comment on lines
+211
to
+215
| refFormats := []string{ | ||
| ref, // Try as a commit hash | ||
| "heads/" + ref, // Try as a branch | ||
| "tags/" + ref, // Try as a tag | ||
| } |
There was a problem hiding this comment.
Eventually I think we will want to try be smarter about using the SHA, heads, or tags ref. Someone could theoretically have the same name for a branch and tag.
I don't think we should address this here, as this PR is enough of an improvement already, but it is something to think of for the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub's API documentation states:
This PR enhances our commit retrieval to align with this specification:
heads/,tags/) when fetching commitsgitHubCommitGetterinterface for better abstraction