chore(vcs): refactor getCommits to use errgroup #3533
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up PR for #3529 (comment).
Refactor the
getCommits
function in the VCS service to useerrgroup
instead ofsync.WaitGroup
.Changes
errgroup
for better concurrency managementNote on error handling
I kept the existing error handling approach, collecting errors explicitly through the channel rather than relying on errgroup's built-in error handling, since it will only return the first encountered error.