fix (v2): add support for ProfileTypes requests #3541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleks-p
commented
Sep 4, 2024
| @@ -138,9 +138,9 @@ func (q *QueryBackend) read( | |||
| } | |||
|
|
|||
| func (q *QueryBackend) withThrottling(fn func() (*queryv1.InvokeResponse, error)) (*queryv1.InvokeResponse, error) { | |||
| defer q.running.Dec() | |||
There was a problem hiding this comment.
this is unrelated, but a previous query-backend based implementation hit an issue where the number of running queries kept going up once the limit was hit
| } | ||
| return connect.NewResponse(&querierv1.ProfileTypesResponse{}), nil | ||
| return Query[querierv1.ProfileTypesRequest, querierv1.ProfileTypesResponse](ctx, r, c, | ||
| func(a, b *querierv1.ProfileTypesResponse) (*querierv1.ProfileTypesResponse, error) { |
There was a problem hiding this comment.
this merges data coming from the v1 and the v2 read paths, when the time range includes the transition between the two
korniltsev
approved these changes
Sep 5, 2024
I agree and I can make the switch to a different method in Grafana. Since it is a public API though and would be used in older Grafana versions we can only mark it as deprecated for now but not remove it. |
aleks-p
force-pushed
the
fix/v2/add-profile-types-request
branch
from
6c93b83 to
eb1d328
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProfileTypes is still used for datasource health checks (see this), therefore we need to have it supported in the v2 read path as well. Adding a simple implementation that collects profile types from the block metadata datasets.
TODO: add unit test