Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(v2): adaptive sharding #3578

Merged
merged 48 commits into from
Oct 17, 2024
Merged

feat(v2): adaptive sharding #3578

merged 48 commits into from
Oct 17, 2024

Conversation

kolesnikovae
Copy link
Collaborator

@kolesnikovae kolesnikovae commented Sep 20, 2024 •
edited
Loading

Please refer to the documentation.

@kolesnikovae
feat: uniform data distribution
3176f76
@kolesnikovae
Merge branch 'main' into feat/dynamic-sharding
3958cc3 
# Conflicts:
#	pkg/experiment/distributor/distributor.go
#	pkg/experiment/distributor/placement/placement.go
@kolesnikovae kolesnikovae changed the title feat: uniform data distribution feat: dynamic data distribution Sep 20, 2024
@kolesnikovae kolesnikovae changed the title feat: dynamic data distribution feat(v2): adaptive sharding Oct 2, 2024
@kolesnikovae kolesnikovae marked this pull request as ready for review October 14, 2024 11:10
@kolesnikovae kolesnikovae requested review from korniltsev and a team as code owners October 14, 2024 11:10
aleks-p
aleks-p approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@aleks-p aleks-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for providing the background with the readme file. The test generating plots is also a great addition!

...iment/distributor/placement/adaptive_placement/adaptive_placementpb/adaptive_placement.proto Show resolved Hide resolved
pkg/experiment/distributor/distribution_key.go Outdated Show resolved Hide resolved
pkg/experiment/distributor/distributor.go Outdated Show resolved Hide resolved
pkg/experiment/distributor/placement/adaptive_placement/store.go Show resolved Hide resolved
pkg/experiment/distributor/placement/adaptive_placement/placement_manager.go Show resolved Hide resolved
pkg/experiment/ingester/client/client.go Show resolved Hide resolved
pkg/experiment/metastore/metastore_state_add_block.go Show resolved Hide resolved
@kolesnikovae
Copy link
Collaborator Author

Thanks for the review @aleks-p!

@kolesnikovae kolesnikovae merged commit 979a583 into main Oct 17, 2024
29 checks passed
@kolesnikovae kolesnikovae deleted the feat/dynamic-sharding branch October 17, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleks-p aleks-p aleks-p approved these changes

@korniltsev korniltsev Awaiting requested review from korniltsev korniltsev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kolesnikovae @aleks-p