-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: k6 middleware #3580
feat: k6 middleware #3580
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
How are these labels being propagated down the communication stream? |
😅 I missed that critical part. I made a few more changes, part of them are dependent on this grafana/pyroscope-go#131. In c794044, I added a mechanism to propagate baggage found in the context as an http header when making a request. This should send the baggage all the way down the call chain when resolving a query. In the With these two changes, any incoming baggage will get read, labeled, and propagated along network calls. Of course, if a service doesn't have |
This is a continuation on work done in collaboration with the k6 team. This PR adds a new configuration option to Pyroscope
which enables an http middleware to tag profiles with k6-specific labels parsed from the request baggage. By default this is disabled.
Go SDK PR: grafana/pyroscope-go#99
k6 PR: https://github.com/grafana/grafana-k6-app/pull/1151